On 12/08/2024 15:41, Depeng Shao wrote:
+static void vfe_reg_update(struct vfe_device *vfe, enum vfe_line_id line_id)
+{
+ int port_id = line_id;
+
+ /* RUP(register update) registers has beem moved to CSID in Titan 780.
+ * Notify the event of trigger RUP.
+ */
+ camss_reg_update(vfe->camss, vfe->id, port_id, false);
+}
+
+static inline void vfe_reg_update_clear(struct vfe_device *vfe,
+ enum vfe_line_id line_id)
+{
+ int port_id = line_id;
+
+ /* RUP(register update) registers has beem moved to CSID in Titan 780.
+ * Notify the event of trigger RUP clear.
+ */
+ camss_reg_update(vfe->camss, vfe->id, port_id, true);
+}
Hmm, so another thought here.
camss_reg_update() is not an accurate name -> camss_rup_update() because
in this case we only update the RUP register, not the AUP or MUP.
reg is an abbreviation for register - but RUP has a defined meaning in
the camera namespace i.e. RUP = register update and its job is to latch
shadow registers to real registers.
camss_rup_update() please.
---
bod
