On Wed, Aug 14 2024 at 19:41, Kevin Chen wrote: > Support for the Aspeed Interrupt Controller found on Aspeed Silicon SoCs, > such as the AST2700, which is arm64 architecture. > > To support ASPEED interrupt controller(INTC) maps the internal interrupt > sources of the AST27XX device to an parent interrupt controller. This still lacks a Signed-off-by: tag and my comment about the error path in the init function is still valid. Do you think that addressing review feedback is optional? Feel free to ignore it, but don't be surprised if I ignore further patches from you. Take your time and go through stuff properly and do not rush out half baked patches in a frenzy. Thanks, tglx