On Fri, Feb 27, 2015 at 10:30:16PM +0000, Bjorn Andersson wrote:
> Add binding documentation for the Qualcomm Hardware Mutex.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>
> ---
>
> I think the conclusion on the dt binding discussion for hwspinlocks was that
> we're down to having the #hwlock-cells intact. So this version includes that,
> but non of the other previously discussed properties.
>
> Changes since v5:
> - Extracted the dt binding documentation into a separate patch
> - Moved the driver to consume a syscon
I'm a little confused here. Why are we now using a syscon? I thought the
set of registers for the block was well-defined.
If there's a link to some previous discussion on that point, it would be
helpful.
Mark.
> - Dropped previously suggested generic hwlock dt bindings
>
> .../devicetree/bindings/hwlock/qcom-hwspinlock.txt | 39 ++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.txt
>
> diff --git a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.txt b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.txt
> new file mode 100644
> index 0000000..28ade7d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.txt
> @@ -0,0 +1,39 @@
> +Qualcomm Hardware Mutex Block:
> +
> +The hardware block provides mutexes utilized between different processors on
> +the SoC as part of the communication protocol used by these processors.
> +
> +- compatible:
> + Usage: required
> + Value type: <string>
> + Definition: must be one of:
> + "qcom,sfpb-mutex",
> + "qcom,tcsr-mutex"
> +
> +- syscon:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: one cell containing:
> + syscon phandle
> + offset of the hwmutex block within the syscon
> + stride of the hwmutex registers
> +
> +- #hwlock-cells:
> + Usage: required
> + Value type: <u32>
> + Definition: must be 1, the specified cell represent the lock id
> + (hwlock standard property, see hwlock.txt)
> +
> +Example:
> +
> + tcsr: syscon@1a400000 {
> + compatible = "qcom,tcsr-msm8974", "syscon";
> + reg = <0xfd484000 0x2000>;
> + };
> +
> + hwlock@fd484000 {
> + compatible = "qcom,tcsr-mutex";
> + syscon = <&tcsr 0 0x80>;
> +
> + #hwlock-cells = <1>;
> + };
> --
> 1.8.2.2
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
