On 13/08/2024 18:16, Conor Dooley wrote:
>>>> +examples:
>>>> + - |
>>>> + i2c {
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> +
>>>> + fan-controller@21 {
>>>> + compatible = "maxim,max31790";
>>>> + reg = <0x21>;
>>>> + clocks = <&sys_clk>;
>>>> + resets = <&reset 0>;
>>>> + };
>>>> + };
>>>
>>> What does this example demonstrate? The one below seems useful, this one
>>> I don't quite understand - what's the point of a fan controller with no
>>> fans connected to it? What am I missing?
>>>
>>
>> Just guessing, but maybe this is supposed to reflect a system which only monitors fan
>> speeds but does not implement fan control.
>
> Even without any control, I would expect to see fan-# child nodes, just
> no pwms property in them. Without the child nodes, how does software
> determine which fan is being monitored by which channel?
Yeah, to me this example is confusing. If device's purpose is to also
monitor, then hardware description in "description:" field should be a
bit extended.
Best regards,
Krzysztof
