Re: [PATCH net-next v3 2/2] net: dsa: microchip: Add KSZ8895/KSZ8864 switch support

[Paolo Abeni <pabeni@xxxxxxxxxx>]

On 8/9/24 23:21, Tristram.Ha@xxxxxxxxxxxxx wrote:
> @@ -542,11 +545,11 @@ static int ksz8_r_sta_mac_table(struct ksz_device *dev, u16 addr,
>   			shifts[STATIC_MAC_FWD_PORTS];
>   	alu->is_override = (data_hi & masks[STATIC_MAC_TABLE_OVERRIDE]) ? 1 : 0;
>   
> -	/* KSZ8795 family switches have STATIC_MAC_TABLE_USE_FID and
> +	/* KSZ8795/KSZ8895 family switches have STATIC_MAC_TABLE_USE_FID and
>   	 * STATIC_MAC_TABLE_FID definitions off by 1 when doing read on the
>   	 * static MAC table compared to doing write.
>   	 */
> -	if (ksz_is_ksz87xx(dev))
> +	if (!ksz_is_ksz88x3(dev))

I think that for consistency and readability the above should be:

	if (ksz_is_ksz87xx(dev) || ksz_is_8895_family(dev))

Thanks,

Paolo