On Tue, 2024-08-13 at 13:02 +0200, Alexander Stein wrote: > Am Dienstag, 13. August 2024, 11:44:28 CEST schrieb Krzysztof Kozlowski: > > On 13/08/2024 11:27, Alexander Stein wrote: > > > Am Dienstag, 13. August 2024, 11:20:08 CEST schrieb Krzysztof Kozlowski: > > > > On 12/08/2024 16:34, Markus Niebel wrote: > > > > > From: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx> > > > > > > > > > > According to microchip,usb2514.yaml the node name shall be usb-hub. > > > > > > > > That's not true. The schema does not say anything like this. Old name is > > > > correct. NAK. > > > > > > So, is the schema incorrect? There is the dtbs_check warning: > > > arch/arm/boot/dts/nxp/imx/imx6q-mba6b.dtb: hub@1: $nodename:0: 'hub@1' does not match '^usb(@.*)?' > > > from schema $id: http://devicetree.org/schemas/usb/microchip,usb2514.yaml# > > > > If you have a warning, shorten it and paste it so this will be obvious. > > If you look at several bindings, the hub is widely used name. I think > > the schema is not correct here - I do not see any properties from > > usb.yaml being used here (for usb2514). What's more, if you compare > > usb2514 with any other on-board HUB representations (because that's the > > only point why we have it in bindings, right?), none of them reference > > usb(-hcd)?.yaml. > > > > These are not USB controllers, IMO. > > I raised that concern in [1] already, but nobody commented. > Besides that, current version of device tree specification [1], section '2.2.2 Generic Names Recommendation' exlicitely suggests 'usb-hub' but not 'hub' See https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.4 > Best regards, > Alexander > > [1] https://lore.kernel.org/all/3633627.mvXUDI8C0e@steina-w/ Best regards, Markus -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/
