On 13/08/2024 11:44, Kevin Chen wrote: > Hi Krzk, > > In ASPEED, ast2400/2500/2600 use arm architecture with KCONFIG_ARCH_ASPEED which slect MACH_ASPEED_G4/G5/G6 in arch/arm/mach-aspeed/Kconfig. > In the fureture, there would be ast2800/2900/... using arm64. We need to clarify the IC generation between 7th/8th/9th/.... > > Maybe change ARCH_ASPEED/MACH_ASPEEDG7 to ARCH_ASPEED first. > Or, do you have better Kconfig usage? Fix your quotes and do not top-post. Please respond inline, instead of top-posting, because it makes your emails hard to follow. https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340 > > >> +config ARCH_ASPEED >> + bool "Aspeed SoC family" >> + select MACH_ASPEED_G7 >> + help >> + Say yes if you intend to run on an Aspeed ast2700 or similar >> + seventh generation Aspeed BMCs. >> + >> +config MACH_ASPEED_G7 >> + bool "Aspeed SoC AST2700" > > There are no MACHines for arm64. Look at this code. Do you see MACH > anywhere else? No. Then why Aspeed must be different? What is this? > > -- > Best Regards, > Kevin. Chen > > ________________________________ > 寄件者: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > 寄件日期: 2024年8月13日 下午 04:50 > 收件者: Kevin Chen <kevin_chen@xxxxxxxxxxxxxx>; tglx@xxxxxxxxxxxxx <tglx@xxxxxxxxxxxxx>; robh@xxxxxxxxxx <robh@xxxxxxxxxx>; krzk+dt@xxxxxxxxxx <krzk+dt@xxxxxxxxxx>; conor+dt@xxxxxxxxxx <conor+dt@xxxxxxxxxx>; joel@xxxxxxxxx <joel@xxxxxxxxx>; andrew@xxxxxxxxxxxxxxxxxxxx <andrew@xxxxxxxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx <devicetree@xxxxxxxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; linux-aspeed@xxxxxxxxxxxxxxxx <linux-aspeed@xxxxxxxxxxxxxxxx> > 主旨: Re: [PATCH v1 2/2] irqchip/aspeed-intc: Add support for 10 INTC interrupts on AST27XX platforms > ... >> diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile >> index 15635812b2d6..d2fe686ae018 100644 >> --- a/drivers/irqchip/Makefile >> +++ b/drivers/irqchip/Makefile >> @@ -84,6 +84,7 @@ obj-$(CONFIG_MVEBU_SEI) += irq-mvebu-sei.o >> obj-$(CONFIG_LS_EXTIRQ) += irq-ls-extirq.o >> obj-$(CONFIG_LS_SCFG_MSI) += irq-ls-scfg-msi.o >> obj-$(CONFIG_ARCH_ASPEED) += irq-aspeed-vic.o irq-aspeed-i2c-ic.o irq-aspeed-scu-ic.o >> +obj-$(CONFIG_MACH_ASPEED_G7) += irq-aspeed-intc.o > > There is no such thing as CONFIG_MACH_ASPEED_G7. And there will never be. > > You already received feedback on this, so why do you keep pushing your > solution? You did not respond to any feedback given, just send the same > and the same till we agree? > > NAK. And this? > >> obj-$(CONFIG_STM32MP_EXTI) += irq-stm32mp-exti.o >> obj-$(CONFIG_STM32_EXTI) += irq-stm32-exti.o >> obj-$(CONFIG_QCOM_IRQ_COMBINER) += qcom-irq-combiner.o >> diff --git a/drivers/irqchip/irq-aspeed-intc.c b/drivers/irqchip/irq-aspeed-intc.c >> new file mode 100644 >> index 000000000000..71407475fb27 > ... > > ************* Email Confidentiality Notice ******************** > 免責聲明: > 本信件(或其附件)可能包含機密資訊，並受法律保護。如 台端非指定之收件者，請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作! > > DISCLAIMER: > This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you. Maybe I am the intended recipient of your message, maybe not. I don't want to have any legal questions regarding upstream, public collaboration, thus probably I should just remove your messages. Please talk with your IT that such disclaimers in open-source are not desired (and maybe even harmful). If you do not understand why, please also see: https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835 If you need to go around company SMTP server, then consider using b4 web-relay: https://b4.docs.kernel.org/en/latest/contributor/send.html Please be informed that by responding to this email you agree that all communications from you and/or your company is made public. In other words, all messages originating from you and/or your company will be made public. You already received exactly this feedback. Around three times. If you keep ignoring feedback, I will keep NAKing your patches. Best regards, Krzysztof
