On 13/08/2024 10:54, Krzysztof Kozlowski wrote: > On 13/08/2024 09:42, Richard Zhu wrote: >> Add dbi2 and iatu reg for i.MX8MQ PCIe EP. >> >> For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the >> driver. This method is not good. >> >> In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"), >> Frank suggests to fetch the dbi2 and atu from DT directly. This commit is >> preparation to do that for i.MX8MQ PCIe EP. >> >> These changes wouldn't break driver function. When "dbi2" and "atu" >> properties are present, i.MX PCIe driver would fetch the according base >> addresses from DT directly. If only two reg properties are provided, i.MX >> PCIe driver would fall back to the old method. >> >> Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx> >> Reviewed-by: Frank Li <Frank.Li@xxxxxxx> > > Stop adding fake tags. This never happened. If it happened, provide lore > link. > Ah, my bad, now I see it. It's fine, sorry. Best regards, Krzysztof