On 13/08/2024 00:07, Jim Quinlan wrote: > On Fri, Aug 2, 2024 at 2:43 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: >> >> On 01/08/2024 00:28, Jim Quinlan wrote: >>> o Change order of the compatible strings to be alphabetical >>> o Use "maxItems" where needed. >> >> I asked at v3 and then in v4 about splitting this. You never responded >> to that comment, so sorry I won't be repeating the same thing in v5. > > I'm sorry Krzyszof, but I just reviewed your responses in V3 and V4 > and I can't find you saying anything about splitting off the above two > bullet points. Perhaps I am somehow losing email responses but all I > see is this in V3 is the following, where you ask me to do a squash, > not a commit: > > [JQ] o Change order of the compatible strings to be alphabetical > []KK] That's a cleanup. You can squash it with a previous patch. > > Now you did say in V3 > > [JQ] o Describe resets/reset-names before using them in rules > [KK] That's a new commit. > > but this bullet item does not relate to the bullet points you have > highlighted in this email. As for your responses to V4, I don't see It exactly relates to the quoted part. The comment is ALWAYS under exact part of your patch being questioned/commented. So first I said one part is cleanup and should be moved away. Then I explained that this part is a NEW COMMIT. New, so one more, different. I understand that this was not clear, but you never came with a question what did I mean. Best regards, Krzysztof
