> -----Original Message----- > From: Shawn Guo <shawnguo2@xxxxxxxx> > Sent: 2024年8月13日 10:51 > To: Hongxing Zhu <hongxing.zhu@xxxxxxx> > Cc: robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > shawnguo@xxxxxxxxxx; l.stach@xxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-pci@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v4 2/4] dts: arm64: imx8mq: Add dbi2 and atu reg for > i.MX8MQ PCIe EP > > On Mon, Jul 29, 2024 at 09:56:43AM +0800, Richard Zhu wrote: > > Add dbi2 and iatu reg for i.MX8MQ PCIe EP. > > > > For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the > > driver. This method is not good. > > > > In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"), > > Frank suggests to fetch the dbi2 and atu from DT directly. This commit > > is preparation to do that for i.MX8MQ PCIe EP. > > > > These changes wouldn't break driver function. When "dbi2" and "atu" > > properties are present, i.MX PCIe driver would fetch the according > > base addresses from DT directly. If only two reg properties are > > provided, i.MX PCIe driver would fall back to the old method. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx> > > Reviewed-by: Frank Li <Frank.Li@xxxxxxx> > > "arm64: dts: ..." for subject prefix. Sorry, would be correct in v5. Best Regards Richard Zhu > > Shawn