Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Saturday, August 10, 2024 7:05 PM > To: Potthuri, Sai Krishna <sai.krishna.potthuri@xxxxxxx>; Linus Walleij > <linus.walleij@xxxxxxxxxx>; Simek, Michal <michal.simek@xxxxxxx>; Rob > Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; > Buddhabhatti, Jay <jay.buddhabhatti@xxxxxxx>; Kundanala, Praveen Teja > <praveen.teja.kundanala@xxxxxxx>; Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-gpio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > saikrishna12468@xxxxxxxxx; git (AMD-Xilinx) <git@xxxxxxx> > Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal > platform > > On 08/08/2024 07:53, Potthuri, Sai Krishna wrote: > >>> 1 file changed, 398 insertions(+) > > > >>> + bias-pull-up: true > >>> + > >>> + bias-pull-down: true > >>> + > >>> + bias-disable: true > >>> + > >>> + input-schmitt-enable: true > >>> + > >>> + input-schmitt-disable: true > >>> + > >>> + bias-high-impedance: true > >>> + > >>> + low-power-enable: true > >>> + > >>> + low-power-disable: true > >> > >> Why do you need to copy all of these? Just switch to > unevaluatedProperties. > > I tried with "unevaluatedProperties: false", it worked but by adding > > this all the properties in the pincfg-node.yaml become valid for this > > platform which is not true. Not all the properties in the pincfg-node.yaml > are supported in this platform. > > So, is there any other way of representing this? > > If they do not make any sense, then sure, you can keep it like this. > Drop the blank lines between each of these, so it will be compact. Ok, will do it. Also, do you agree with my comments which I replied in other thread? Pasting those comments below for reference, > sd1_wp_0_grp, sd1_wp_1_grp, > > + ospi0_0_grp, ospi0_ss_0_grp, qspi0_0_grp, > qspi0_fbclk_0_grp, qspi0_ss_0_grp, > > + test_clk_0_grp, test_scan_0_grp, tamper_trigger_0_grp] > > + maxItems: 78 > > You miss minItems... I have doubts this was really tested. groups/pins are mentioned as required property. Do we still need to define minItems? .... > > + > > + drive-strength: > > drive-strength-microamp In this case, values are in mA. Do we still need to use drive-strength-microamp? Regards Sai Krishna
