Hi Christian, kernel test robot noticed the following build errors: [auto build test ERROR on atorgue-stm32/stm32-next] [also build test ERROR on robh/for-next linus/master v6.11-rc3 next-20240812] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Christian-Bruel/MAINTAINERS-add-entry-for-ST-STM32MP25-COMBOPHY-driver/20240812-201003 base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next patch link: https://lore.kernel.org/r/20240812120529.3564390-4-christian.bruel%40foss.st.com patch subject: [PATCH 3/5] phy: stm32: Add support for STM32MP25 COMBOPHY. config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20240813/202408130447.IzvuJERR-lkp@xxxxxxxxx/config) compiler: arceb-elf-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240813/202408130447.IzvuJERR-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202408130447.IzvuJERR-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/phy/st/phy-stm32-combophy.c: In function 'stm32_impedance_tune': >> drivers/phy/st/phy-stm32-combophy.c:134:36: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration] 134 | FIELD_PREP(STM32MP25_PCIEPRG_IMPCTRL_OHM, imp_of)); | ^~~~~~~~~~ >> drivers/phy/st/phy-stm32-combophy.c:137:26: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration] 137 | imp_of = FIELD_GET(STM32MP25_PCIEPRG_IMPCTRL_OHM, val); | ^~~~~~~~~ cc1: some warnings being treated as errors vim +/FIELD_PREP +134 drivers/phy/st/phy-stm32-combophy.c 107 108 static int stm32_impedance_tune(struct stm32_combophy *combophy) 109 { 110 u8 imp_size = ARRAY_SIZE(imp_lookup); 111 u8 vswing_size = ARRAY_SIZE(imp_lookup[0].vswing); 112 u8 imp_of, vswing_of; 113 u32 max_imp = imp_lookup[0].microohm; 114 u32 min_imp = imp_lookup[imp_size - 1].microohm; 115 u32 max_vswing = imp_lookup[imp_size - 1].vswing[vswing_size - 1]; 116 u32 min_vswing = imp_lookup[0].vswing[0]; 117 u32 val; 118 119 if (!of_property_read_u32(combophy->dev->of_node, "st,output-micro-ohms", &val)) { 120 if (val < min_imp || val > max_imp) { 121 dev_err(combophy->dev, "Invalid value %u for output ohm\n", val); 122 return -EINVAL; 123 } 124 125 for (imp_of = 0 ; imp_of < ARRAY_SIZE(imp_lookup); imp_of++) 126 if (imp_lookup[imp_of].microohm <= val) 127 break; 128 129 dev_dbg(combophy->dev, "Set %u micro-ohms output impedance\n", 130 imp_lookup[imp_of].microohm); 131 132 regmap_update_bits(combophy->regmap, SYSCFG_PCIEPRGCR, 133 STM32MP25_PCIEPRG_IMPCTRL_OHM, > 134 FIELD_PREP(STM32MP25_PCIEPRG_IMPCTRL_OHM, imp_of)); 135 } else { 136 regmap_read(combophy->regmap, SYSCFG_PCIEPRGCR, &val); > 137 imp_of = FIELD_GET(STM32MP25_PCIEPRG_IMPCTRL_OHM, val); 138 } 139 140 if (!of_property_read_u32(combophy->dev->of_node, "st,output-vswing-microvolt", &val)) { 141 if (val < min_vswing || val > max_vswing) { 142 dev_err(combophy->dev, "Invalid value %u for output vswing\n", val); 143 return -EINVAL; 144 } 145 146 for (vswing_of = 0 ; vswing_of < ARRAY_SIZE(imp_lookup[imp_of].vswing); vswing_of++) 147 if (imp_lookup[imp_of].vswing[vswing_of] >= val) 148 break; 149 150 dev_dbg(combophy->dev, "Set %u microvolt swing\n", 151 imp_lookup[imp_of].vswing[vswing_of]); 152 153 regmap_update_bits(combophy->regmap, SYSCFG_PCIEPRGCR, 154 STM32MP25_PCIEPRG_IMPCTRL_VSWING, 155 FIELD_PREP(STM32MP25_PCIEPRG_IMPCTRL_VSWING, vswing_of)); 156 } 157 158 return 0; 159 } 160 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
