Re: [PATCH v2 1/2] dt-bindings: pwm: Document Airoha EN7581 PWM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/08/2024 11:58, Lorenzo Bianconi wrote:
>> On 11/08/2024 18:34, Lorenzo Bianconi wrote:
>>> From: Christian Marangi <ansuelsmth@xxxxxxxxx>
>>>
>>> Document required property for the Airoha EN7581 PWM. The device
>>> requires 3 different address for the sgpio, flash and cycle config.
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>
>> That's odd placement. Which tool placed it that way?
> 
> I placed it manually. Do you prefer to put the Reviewed-by tag at the end if
> the patch is unchanged?

Please do not place tags manually unless you carefully follow submitting
patches and DCO process. Use b4 for this.

Tag must be moved further, because here it is placed incorrectly.
Christian did not send this patch after receiving my review. I did not
review it before he wrote it, either.


Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux