Hi, On 09.08.24 10:21, Oleksij Rempel wrote: > Rename 'pins1' to 'pins' in the qspi_bk1_pins_a node to correct the > subnode name. The incorrect name caused the configuration to be > applied to the wrong subnode, resulting in QSPI not working properly. > > To avoid this kind of regression, all references to pin configuration > nodes are now referenced directly using the format &{label/subnode}. > > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> Reviewed-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> > +&{sdmmc1_b4_pins_a/pins2} { > + /delete-property/ bias-disable; Nit: a heads-up in the commit message would've been appropriate. Same goes for driver-push-pull, which disappeared, because it was redundant. > + bias-pull-up; > }; Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |