On 09/08/2024 07:59, Macpaul Lin wrote:
>
>
> On 8/8/24 20:05, Krzysztof Kozlowski wrote:
>>
>>
>> External email : Please do not click links or open attachments until you
>> have verified the sender or the content.
>>
>> On 07/08/2024 12:32, Macpaul Lin wrote:
>>>>> + - |
>>>>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>>>>> +
>>>>> + pwrap {
>>>>> + pmic {
>>>>> + compatible = "mediatek,mt6397";
>>>>
>>>> Messed indentation.
>>>>
>>>> Use 4 spaces for example indentation.
>>>>
>>>> Anyway, drop top node or better move the example to the parent device
>>>> schema making it complete.
>>
>> Look at this comment. I asked you to move to the parent device schema...
>>
>> Best regards,
>> Krzysztof
>>
>
> I would like to ensure that the progress can be made step by step.
>
> Since I am not specifically responsible for this driver, I cannot
> determine when I will be able to modify the next file after completing
> one today.
> Will it be tomorrow? Perhaps in a few months?
> There is also the possibility that I might have to pause midway due to
> other job assignments.
>
> Additionally, I need to obtain approval from other internal colleagues.
> I am pleased to have received permission to modify
> mfd/mediatek,mt6397.yaml the day after I submitted this conversion of
> mt6397-regulator.
Heh, that's surprising. Anyone can change any piece of code, that's the
beauty of open-source.
>
> I was intend to split the example parts of the patches into 3 parts
> seprately, mt6397-regulator.yaml, mfd/mediatek,mt6397.yaml,i
> then moving the examples from mt6397-regulator.yaml to
> mfd/mediatek,mt6397.yaml, move the content to parent device step by step.
>
> I will include the example part in next version patch in
> mfd/mediatek,mt6397.yaml.
Sure, do it step-by-step, but then due to dependencies wait till each
one gets into released kernel...
Best regards,
Krzysztof
