Re: [PATCH v9 4/5] wifi: brcmfmac: Add optional lpo clock enable support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On August 10, 2024 5:52:11 AM Jacobe Zang <jacobe.zang@xxxxxxxxxx> wrote:

WiFi modules often require 32kHz clock to function. Add support to
enable the clock to PCIe driver and move "brcm,bcm4329-fmac" check
to the top of brcmf_of_probe. Change function prototypes from void
to int and add appropriate errno's for return values that will be
send to bus when error occurred.

Co-developed-by: Ondrej Jirman <megi@xxxxxx>
Signed-off-by: Ondrej Jirman <megi@xxxxxx>
Co-developed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Signed-off-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Signed-off-by: Jacobe Zang <jacobe.zang@xxxxxxxxxx>
---
.../broadcom/brcm80211/brcmfmac/bcmsdh.c      |  4 +-
.../broadcom/brcm80211/brcmfmac/common.c      |  3 +-
.../wireless/broadcom/brcm80211/brcmfmac/of.c | 53 +++++++++++--------
.../wireless/broadcom/brcm80211/brcmfmac/of.h |  9 ++--
.../broadcom/brcm80211/brcmfmac/pcie.c        |  3 ++
.../broadcom/brcm80211/brcmfmac/sdio.c        | 24 ++++++---
.../broadcom/brcm80211/brcmfmac/usb.c         |  3 ++
7 files changed, 63 insertions(+), 36 deletions(-)

[...]

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index 6b38d9de71af6..461b7ff3be24b 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c

[...]

@@ -4474,8 +4480,10 @@ struct brcmf_sdio *brcmf_sdio_probe(struct brcmf_sdio_dev *sdiodev)
 bus->brcmf_wq = wq;

 /* attempt to attach to the dongle */
- if (!(brcmf_sdio_probe_attach(bus))) {
+ probe_attach_result = brcmf_sdio_probe_attach(bus);

There is no need for probe_attach_result anymore. Just use ret variable instead.

+ if (probe_attach_result < 0) {
 brcmf_err("brcmf_sdio_probe_attach failed\n");
+ ret = probe_attach_result;
 goto fail;
 }






[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux