On Tue, 06 Aug 2024 19:54:56 +0200 Barnabás Czémán <barnabas.czeman@xxxxxxxxxxxxxx> wrote: > On August 6, 2024 6:19:25 PM GMT+02:00, Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > >On Tue, 06 Aug 2024 08:10:18 +0200 > >Barnabás Czémán <barnabas.czeman@xxxxxxxxxxxxxx> wrote: > > > >Hi Barnabás, > > > >Welcome to IIO. > > > >> ST2 register read should be placed after read measurment data, > >> because it will get correct values after it. > > > >What is the user visible result of this? Do we detect errors when none > >are there? Do we have a datasheet reference for the status being > >update on the read command, not after the trigger? > > Second read will fail. In the datasheet ST2 comes after measurment data read. Here is some explanation from datasheet. > > "When ST2 register is read, AK09918 judges that data reading is finished. Stored measurement data is > protected during data reading and data is not updated. By reading ST2 register, this protection is > released. It is required to read ST2 register after data reading." > Thanks. Please add more of that detail to the patch description for v3. > So if ST2 is read before measurment it will stuck at protected mode. > >> > >Needs a Fixes tag to let us know how far to backport the fix. > I think it is broken since 09912 was added but i cannot verify i have only devices with 09918. > > I wasn't meaning devices, but rather what patch broke the kernel code. It might be the original driver introduction. If we can add a Fixes tag that makes it much easier for stable + distributions to work out whether to pick the fix up or not.
