On Wed, Mar 11, 2015 at 10:28 AM, Murali Karicheri <m-karicheri2@xxxxxx> wrote: > On 03/11/2015 08:49 AM, Russell King - ARM Linux wrote: >> >> On Wed, Mar 11, 2015 at 07:35:45AM -0500, Rob Herring wrote: >>> >>> On Tue, Mar 10, 2015 at 10:25 AM, Murali Karicheri<m-karicheri2@xxxxxx> >>> wrote: >>>> >>>> On some platforms such as that based on x86, ia64 etc, root bus is >>>> created with parent node passed in as NULL to pci_create_root_bus(). >>>> On these platforms, the patch series "PCI: get DMA configuration from >>>> parent device" when applied causes kernel crash. So add a check for this >>>> in of_pci_dma_configure() >>> >>> >>> Wouldn't these arches have OF disabled and call an empty function? >>> Regardless, we still need this. >>> >>>> Signed-off-by: Murali Karicheri<m-karicheri2@xxxxxx> >>> >>> >>> I'm assuming Bjorn will apply this. >>> >>> Acked-by: Rob Herring<robh@xxxxxxxxxx> >> >> >> It might be an idea to read the subject line... >> >> "fix BUG: unable to handle kernel" > > Russell, > > I will fix the subject as "fix BUG: unable to handle kernel NULL pointer" > and re-send. Russell's point is the subject applies to every fix for a BUG. Something like "of/pci: fix of_pci_dma_configure parent ptr NULL dereference". Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
