On Friday, 9 August 2024 10:59:58 EDT Conor Dooley wrote: > On Thu, Aug 08, 2024 at 12:31:04PM -0400, Detlev Casanova wrote: > > From: Finley Xiao <finley.xiao@xxxxxxxxxxxxxx> > > > > Define power domain IDs as described in the TRM and add compatible for > > rockchip,rk3576-power-controller > > > > Signed-off-by: Finley Xiao <finley.xiao@xxxxxxxxxxxxxx> > > [reword, add yaml] > > To be honest, both here and in your other patch, you should remove this > [] section and add a co-develop-ed-by instead. That seems to be used quite often though, I like how it gives an idea of what has been adapted from downstream patches. > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > > Signed-off-by: Detlev Casanova <detlev.casanova@xxxxxxxxxxxxx> > > --- > > > > .../power/rockchip,power-controller.yaml | 1 + > > .../dt-bindings/power/rockchip,rk3576-power.h | 30 +++++++++++++++++++ > > 2 files changed, 31 insertions(+) > > create mode 100644 include/dt-bindings/power/rockchip,rk3576-power.h > > > > diff --git > > a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml > > b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml > > index 0d5e999a58f1b..650dc0aae6f51 100644 > > --- > > a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml > > +++ > > b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml> > > @@ -41,6 +41,7 @@ properties: > > - rockchip,rk3368-power-controller > > - rockchip,rk3399-power-controller > > - rockchip,rk3568-power-controller > > > > + - rockchip,rk3576-power-controller > > > > - rockchip,rk3588-power-controller > > - rockchip,rv1126-power-controller > > > > diff --git a/include/dt-bindings/power/rockchip,rk3576-power.h > > b/include/dt-bindings/power/rockchip,rk3576-power.h new file mode 100644 > > index 0000000000000..324a056aa8512 > > --- /dev/null > > +++ b/include/dt-bindings/power/rockchip,rk3576-power.h > > @@ -0,0 +1,30 @@ > > +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ > > +#ifndef __DT_BINDINGS_POWER_RK3576_POWER_H__ > > +#define __DT_BINDINGS_POWER_RK3576_POWER_H__ > > + > > +/* VD_NPU */ > > +#define RK3576_PD_NPU 0 > > +#define RK3576_PD_NPUTOP 1 > > +#define RK3576_PD_NPU0 2 > > +#define RK3576_PD_NPU1 3 > > + > > +/* VD_GPU */ > > +#define RK3576_PD_GPU 4 > > + > > +/* VD_LOGIC */ > > +#define RK3576_PD_NVM 5 > > +#define RK3576_PD_SDGMAC 6 > > +#define RK3576_PD_USB 7 > > +#define RK3576_PD_PHP 8 > > +#define RK3576_PD_SUBPHP 9 > > +#define RK3576_PD_AUDIO 10 > > +#define RK3576_PD_VEPU0 11 > > +#define RK3576_PD_VEPU1 12 > > +#define RK3576_PD_VPU 13 > > +#define RK3576_PD_VDEC 14 > > +#define RK3576_PD_VI 15 > > +#define RK3576_PD_VO0 16 > > +#define RK3576_PD_VO1 17 > > +#define RK3576_PD_VOP 18 > > + > > +#endif
