On Thu, Aug 8, 2024 at 5:09 PM Hsin-Te Yuan <yuanhsinte@xxxxxxxxxxxx> wrote: > > Add trip points to the tboard1 and tboard2 thermal zones to ensure they > are registered successfully. The position of tboard_thermistor2 is different between end devices. And both sensors are outside of the SoC. Having such a high trip point probably doesn't help with keeping the device or user safe. The SoC itself also has internal sensors which would be more suited for this. So I think it makes more sense to have the kernel not require trip points for thermal zones, matching what the thermal binding says. I resurrected an old patch for this [1]. ChenYu [1] https://lore.kernel.org/linux-arm-kernel/20240809070822.2835371-1-wenst@xxxxxxxxxxxx/ > Signed-off-by: Hsin-Te Yuan <yuanhsinte@xxxxxxxxxxxx> > --- > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > index 6345e969efae..1593ea14f81f 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > @@ -978,12 +978,38 @@ tboard1 { > polling-delay = <1000>; /* milliseconds */ > polling-delay-passive = <0>; /* milliseconds */ > thermal-sensors = <&tboard_thermistor1>; > + trips { > + tboard1_alert: trip-alert { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + tboard1_crit: trip-crit { > + temperature = <100000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > }; > > tboard2 { > polling-delay = <1000>; /* milliseconds */ > polling-delay-passive = <0>; /* milliseconds */ > thermal-sensors = <&tboard_thermistor2>; > + trips { > + tboard2_alert: trip-alert { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + tboard2_crit: trip-crit { > + temperature = <100000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > }; > }; > > > --- > base-commit: 21b136cc63d2a9ddd60d4699552b69c214b32964 > change-id: 20240801-kukui_trip-6625c0a54c50 > > Best regards, > -- > Hsin-Te Yuan <yuanhsinte@xxxxxxxxxxxx> > >
