On 10:26-20240808, Manorit Chawdhry wrote:
> Hi Nishanth,
>
> On 08:20-20240807, Nishanth Menon wrote:
> > On 22:40-20240731, Manorit Chawdhry wrote:
> > > k3-j784s4-j742s2-main-common.dtsi will be included in k3-j742s2-main.dtsi at a
> > > later point so move j784s4 related stuff to k3-j784s4-main.dtsi
> > >
> > > Signed-off-by: Manorit Chawdhry <m-chawdhry@xxxxxx>
> > > ---
> > > .../boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi | 13 -------------
> > > arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 21 +++++++++++++++++++++
> > > arch/arm64/boot/dts/ti/k3-j784s4.dtsi | 2 ++
> > > 3 files changed, 23 insertions(+), 13 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
> > > index 17abd0f1560a..91352b1f63d2 100644
> > > --- a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
> > > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
> > > @@ -2405,19 +2405,6 @@ c71_2: dsp@66800000 {
> > > status = "disabled";
> > > };
> > >
> > > - c71_3: dsp@67800000 {
> > > - compatible = "ti,j721s2-c71-dsp";
> > > - reg = <0x00 0x67800000 0x00 0x00080000>,
> > > - <0x00 0x67e00000 0x00 0x0000c000>;
> > > - reg-names = "l2sram", "l1dram";
> > > - ti,sci = <&sms>;
> > > - ti,sci-dev-id = <40>;
> > > - ti,sci-proc-ids = <0x33 0xff>;
> > > - resets = <&k3_reset 40 1>;
> > > - firmware-name = "j784s4-c71_3-fw";
> > > - status = "disabled";
> > > - };
> > > -
> >
> > This patch can be squashed in.
> >
>
> The idea was that we can see what changes are happening and where are
> things getting moved and hence had kept the patch like this, would be
> easier to review I believe, do you want it squashed right now or should
> I be doing it later once you are fine with all the changes and all the
> reviews are done?
>
No. Please squash as suggested in my response to your cover-letter for
the next iteration - please use git format-patch -C -M to generate
patches (I understand you have some limitations with using b4) to
make reviews easier to do.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
