Re: [PATCH] arm64: dts: ti: k3-am68-sk-base-board: Add clklb pin mux for mmc1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bhavya

On 08/08/24 13:08, Bhavya Kapoor wrote:
Hi Neha,

On 08/08/24 11:51 am, Neha Malcom Francis wrote:
Hi Bhavya

On 07/08/24 15:46, Bhavya Kapoor wrote:
mmc1 was not functional since pin mux for clklb was not present.
Thus, add clklb pin mux to get MMC working.

Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board")
Signed-off-by: Bhavya Kapoor <b-kapoor@xxxxxx>
---

rebased to next-20240807

  arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
index 90dbe31c5b81..d5ceab79536c 100644
--- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
@@ -204,6 +204,7 @@ main_mmc1_pins_default: main-mmc1-default-pins {
          pinctrl-single,pins = <
              J721S2_IOPAD(0x104, PIN_INPUT, 0) /* (P23) MMC1_CLK */
              J721S2_IOPAD(0x108, PIN_INPUT, 0) /* (N24) MMC1_CMD */
+            J721S2_IOPAD(0x100, PIN_INPUT, 0) /* (###) MMC1_CLKLB */
              J721S2_IOPAD(0x0fc, PIN_INPUT, 0) /* (M23) MMC1_DAT0 */
              J721S2_IOPAD(0x0f8, PIN_INPUT, 0) /* (P24) MMC1_DAT1 */
              J721S2_IOPAD(0x0f4, PIN_INPUT, 0) /* (R24) MMC1_DAT2 */

How is this different from the P23 pinmux for MMC1_CLK? Could you explain what CLKLB is, since it doesn't have a ball number I'm finding it difficult to understand what it is?

This pin needs to be setup so that MMC_CLK is looped back at pad level for highspeed SDIO operations (has been same across K3 family). MMC0/1 has this pin configured as INPUT by reset default as these have boot media

 These pinmuxes are derived from pinmux file shared by EVM team during wakeup/board bringup.


Thank you for explaining.

Reviewed-by: Neha Malcom Francis <n-francis@xxxxxx>

Regards


--
Thanking You
Neha Malcom Francis




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux