On 2024-08-07 19:28, Florian Klink wrote:
On Wed, Aug 07, 2024 at 07:17:49PM GMT, Heiko Stübner wrote:
Am Mittwoch, 7. August 2024, 19:15:03 CEST schrieb Dragan Simic:
On 2024-08-07 19:00, Florian Klink wrote:
> This follows the same logic as 82d40b141a4c ("arm64: dts: rockchip: add
> rfkill node for M.2 Key E WiFi on rock-5b").
>
> On the orangepi-5-plus, there's also a GPIO pin connecting the WiFi
> enable signal inside the M.2 Key E slot.
>
> The exact GPIO PIN can be validated in the Armbian rk-5.10-rkr4 kernel
> rk3588-orangepi-5-plus.dtsi file [1], which contains a `wifi_disable`
> node referencing RK_PC4 on &gpio0.
>
> Signed-off-by: Florian Klink <flokli@xxxxxxxxx>
> Tested-by: Florian Klink <flokli@xxxxxxxxx>
> Link:
> https://github.com/armbian/linux-rockchip/blob/9fbe23c9da24f236c6009f42d3f02c1ffb84c169/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> [1]
Unfortunately, this isn't how the "Link: ..." tag is to be used, or
how
a reference is to be provided. Please see the patch submission
linked
below for a correct example of providing links as references.
https://lore.kernel.org/linux-rockchip/4449f7d4eead787308300e2d1d37b88c9d1446b2.1717308862.git.dsimic@xxxxxxxxxxx/T/#u
please also don't post v2 patches as replies to v1.
Instead start a new mail thread please.
A lot of tooling cannot really find the correct version in such
multiversion threads.
sorry for the noise. I sent a v3, addressing the requested changes, as
a
new thread.
Somewhat offtopic for this patch, but it'd be great if
process/submitting-patches.html could include:
- A mention of the kernel quotation style for commit ids and subjects
and how to produce them
- A styleguide for how to link to references
- An active discouragement from using --in-reply-to for v2 (which
differs from what `git send-email` proposes).
I'd suggest that you go ahead and whip up a new patch that adds those
specific instructions to the documentation.
