On 07/08/2024 14:39, Krzysztof Kozlowski wrote: > On 07/08/2024 14:33, Depeng Shao wrote: >> Add CAMSS block definition for sm8550. >> >> This drop contains definitions for the following components on sm8550: > > 1. Subject: there is no prefix camss. There is no such file, directory > or module. > > 2. You already sent this, so this should be v2 or v3 or vX. Provide > changelog under ---. > > If there is going to be resend, please fix above. > > 3. If this was tested on aim300, I am surprised this being not enabled > on aim300. One more thing, bindings were not accepted, thus this patch should not go in. There were no new bindings, so I assume patchset is using rejected ones. It's fine to send it to get some comments, although would be nice to mention to maintainer that this cannot be picked up as is. :( Best regards, Krzysztof
