On 10:56-20240807, Manorit Chawdhry wrote:
> Hi Nishanth,
>
> On 10:07-20240806, Nishanth Menon wrote:
> > On 09:43-20240806, Andrew Davis wrote:
> > > On 7/30/24 4:53 AM, Manorit Chawdhry wrote:
> > > > Adds bootph-* properties to the leaf nodes to enable U-boot to
> > > > utilise them.
> > >
> > > U-Boot? Let's try to pretend like this is a generic property and
> > > just say "bootloader" :)
> > > > @@ -445,6 +446,7 @@ flash@0 {
> > > > cdns,tchsh-ns = <60>;
> > > > cdns,tslch-ns = <60>;
> > > > cdns,read-delay = <4>;
> > > > + bootph-all;
> >
> > Here and elsewhere, follow:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117
>
> Could you tell me what are you seeing wrong? The dts-coding-style that
> you shared doesn't tell a specific location for bootph-* properties so
> using the generic reasoning.
it falls under standard properties
>
> "1. Most important properties start the node: compatible then bus addressing to
> match unit address."
>
> This is the least important property considering Linux and hence the
> reasoning was that it should come in the last. Also, j722s and am62p
> follow the same convention so it was taken from there only.
follow the order - bootph-all is before the vendor properties
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
