On 07/08/2024 10:28, ivo.ivanov.ivanov1@xxxxxxxxx wrote:
> From: Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx>
>
> Samsung Galaxy S8 (SM-G950F), codenamed dreamlte, is a mobile phone
> from 2017. It features 4GB RAM, 64GB UFS 2.1, Exynos 8895 SoC and a
> 1440x2960 Super AMOLED display.
>
> This initial device tree enables SimpleFB, PSTORE and GPIO keys.
>
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx>
> ---
> arch/arm64/boot/dts/exynos/Makefile | 1 +
> .../boot/dts/exynos/exynos8895-dreamlte.dts | 126 ++++++++++++++++++
> 2 files changed, 127 insertions(+)
> create mode 100644 arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dts
>
> diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile
> index d7f2191c2..18f5a3eed 100644
> --- a/arch/arm64/boot/dts/exynos/Makefile
> +++ b/arch/arm64/boot/dts/exynos/Makefile
> @@ -7,5 +7,6 @@ dtb-$(CONFIG_ARCH_EXYNOS) += \
> exynos7-espresso.dtb \
> exynos7885-jackpotlte.dtb \
> exynos850-e850-96.dtb \
> + exynos8895-dreamlte.dtb \
> exynosautov9-sadk.dtb \
> exynosautov920-sadk.dtb
> diff --git a/arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dts b/arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dts
> new file mode 100644
> index 000000000..5c8351b99
> --- /dev/null
> +++ b/arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dts
> @@ -0,0 +1,126 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Samsung Galaxy S8 (dreamlte/SM-G950F) device tree source
> + *
> + * Copyright (c) 2024, Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx>
> + */
> +
> +/dts-v1/;
> +#include "exynos8895.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +
> +/ {
> + model = "Samsung Galaxy S8 (SM-G950F)";
> + compatible = "samsung,dreamlte", "samsung,exynos8895";
> + chassis-type = "handset";
> +
> + chosen {
> + #address-cells = <2>;
> + #size-cells = <1>;
> + ranges;
> +
> + framebuffer0: framebuffer@cc000000 {
> + status= "okay";
Drop, it was not disabled. Also, please follow DTS coding style
regarding order of properties.
> + compatible = "simple-framebuffer";
Best regards,
Krzysztof
