On 06/08/2024 23:42, Richard Acayan wrote:
Add the camera subsystem and CCI used to interface with cameras on the
Snapdragon 670.
Signed-off-by: Richard Acayan <mailingradian@xxxxxxxxx>
+
+ camcc: clock-controller@ad00000 {
+ compatible = "qcom,sdm845-camcc";
+ reg = <0 0x0ad00000 0 0x10000>;
+ clocks = <&rpmhcc RPMH_CXO_CLK>;
+ clock-names = "bi_tcxo";
+ #clock-cells = <1>;
+ #reset-cells = <1>;
+ #power-domain-cells = <1>;
+ };
+
You're adding camcc here too which is inconsistent with the commit log.
Personally I'm a fan, perhaps the only fan, of very granular patches and
I'd break this up - at a minimum into
1. Adding CAMCC
2. Adding CCI and CAMSS
---
bod
