On 06/08/2024 14:03, Oleksij Rempel wrote: > From: David Jander <david@xxxxxxxxxxx> > > Introduce device tree support for the MECIO1 and MECT1S board variants. > MECIO1 is an I/O and motor control board used in blood sample analysis > machines. MECT1S is a 1000Base-T1 switch for internal machine networks > of blood sample analysis machines. > > Signed-off-by: David Jander <david@xxxxxxxxxxx> > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> > --- > .../devicetree/bindings/arm/stm32/stm32.yaml | 8 + > arch/arm/boot/dts/st/Makefile | 3 + > arch/arm/boot/dts/st/stm32mp151c-mecio1r0.dts | 48 ++ > arch/arm/boot/dts/st/stm32mp151c-mect1s.dts | 297 ++++++++++ > arch/arm/boot/dts/st/stm32mp153c-mecio1r1.dts | 48 ++ > .../arm/boot/dts/st/stm32mp15x-mecio1-io.dtsi | 533 ++++++++++++++++++ > 6 files changed, 937 insertions(+) > create mode 100644 arch/arm/boot/dts/st/stm32mp151c-mecio1r0.dts > create mode 100644 arch/arm/boot/dts/st/stm32mp151c-mect1s.dts > create mode 100644 arch/arm/boot/dts/st/stm32mp153c-mecio1r1.dts > create mode 100644 arch/arm/boot/dts/st/stm32mp15x-mecio1-io.dtsi > > diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > index 58099949e8f3a..703d4b574398d 100644 > --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml Please run scripts/checkpatch.pl and fix reported warnings. Then please run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > @@ -54,6 +54,8 @@ properties: > - description: ST STM32MP151 based Boards > items: > - enum: > + - prt,mecio1r0 # Protonic MECIO1r0 > + - prt,mect1s # Protonic MECT1S > - prt,prtt1a # Protonic PRTT1A > - prt,prtt1c # Protonic PRTT1C ... Best regards, Krzysztof