On Wed, Jul 31, 2024 at 11:24:24PM +0200, Heiko Stuebner wrote: > These MCUs can be found in network attached storage devices made by QNAP. > They are connected to a serial port of the host device and provide > functionality like LEDs, power-control and temperature monitoring. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx> > --- > .../bindings/mfd/qnap,ts433-mcu.yaml | 43 +++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml b/Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml > new file mode 100644 > index 0000000000000..5ae19d8faedbd > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml > @@ -0,0 +1,43 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/qnap,ts433-mcu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: QNAP NAS on-board Microcontroller > + > +maintainers: > + - Heiko Stuebner <heiko@xxxxxxxxx> > + > +description: > + QNAP embeds a microcontroller on their NAS devices adding system feature > + as PWM Fan control, additional LEDs, power button status and more. Doesn't really look like the binding is complete. > + > +properties: > + compatible: > + enum: > + - qnap,ts433-mcu > + > + "#cooling-cells": > + const: 2 > + > + cooling-levels: > + description: PWM duty cycle values corresponding to thermal cooling states. > + $ref: /schemas/types.yaml#/definitions/uint32-array > + items: > + maximum: 255 These are fan properties and should be in a "fan" node referencing hwmon/fan-common.yaml. Rob
