On 05/08/2024 18:39, Bjorn Andersson wrote: >>> >>> In patch1 we are trying to add reference of i2c-adapter, you suggested >>> to use i2c-bus for that. we got comments on the driver code not to use >>> adapter and instead use i2c client reference. I felt i2c-bus is not >>> ideal to represent i2c client device so used this name. >> >> You did not respond to comment of using i2c-bus, just silently decided >> to implement other property. >> > > I guess you totally ignored my comment when you reviewed the previous > version, where I asked him to represent the device on said bus. Hm, Rob suggested i2c-bus, you as well: <<I'd prefer you call it "i2c-adapter" or perhaps "i2c-bus", because it's not "the switch controller".>> and there was no response to any of these comments. > >> Anyway, why i2c-bus is not suitable here? I am quite surprised... >> > > I was not aware that i2c-bus was an acceptable solution, sorry for my > bad suggestion and guidance here. I think you suggested i2c-bus as well, but regardless what did you agree internally, response to Rob was expected. Best regards, Krzysztof
