Hi Benjamin,
On Mon, Aug 5, 2024 at 10:33 AM Benjamin Hahn <B.Hahn@xxxxxxxxx> wrote:
> +/* TPM */
> +&ecspi1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + cs-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
> + num-cs = <1>;
num-cs is not needed.
The number of chip selects can be retrieved from cs-gpios.
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ecspi1 &pinctrl_ecspi1_cs>;
> + status = "okay";
> +
> + tpm: tpm_tis@0 {
Node names should be generic.
Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml suggests 'tpm', so:
tpm: tmp@0 {
> &iomuxc {
> + pinctrl_ecspi1: ecspi1grp {
> + fsl,pins = <
> + MX8MP_IOMUXC_ECSPI1_MISO__ECSPI1_MISO 0x80
> + MX8MP_IOMUXC_ECSPI1_MOSI__ECSPI1_MOSI 0x80
> + MX8MP_IOMUXC_ECSPI1_SCLK__ECSPI1_SCLK 0x80
> + >;
> + };
> +
> + pinctrl_ecspi1_cs: ecspi1csgrp {
> + fsl,pins = <
> + MX8MP_IOMUXC_ECSPI1_SS0__GPIO5_IO09 0x00
Maybe simpler to put MX8MP_IOMUXC_ECSPI1_SS0__GPIO5_IO09 as part of
pinctrl_ecspi1.
