On Tue, 30 Jul 2024 11:05:08 +0800 Mariel Tinaco <Mariel.Tinaco@xxxxxxxxxx> wrote: > This adds the bindings documentation for the 14-bit > High Voltage, High Current, Waveform Generator > Digital-to-Analog converter. > A few additions to Krzysztof's much more detailed review. Wrap patch descriptions to 75 chars. not sub 55. > Signed-off-by: Mariel Tinaco <Mariel.Tinaco@xxxxxxxxxx> > + > + adi,rset-ohms: Please rename this as rset sounds like reset to me. Not sure what a good name is however! > + description: Specify value of external resistor connected to FS_ADJ pin > + to establish internal HVDAC's reference current I_REF > + default: 2000 > + minimum: 2000 > + maximum: 20000 > +