On Fri, Aug 2, 2024, at 21:20, Dmitry Baryshkov wrote: > On Fri, 2 Aug 2024 at 12:05, Kevin Chen <kevin_chen@xxxxxxxxxxxxxx> wrote: >> >> Enable CONFIG_ARCH_ASPEED in arm64 defconfig. > > Why? Usually the defconfig changes have "Enable CONFIG_FOO as it is > used on the Bar Baz platform" commit message. I would also expect to see aspeed specific device drivers to get enabled in the same commit. On arm32, I see CONFIG_ASPEED_KCS_IPMI_BMC=m CONFIG_ASPEED_BT_IPMI_BMC=m CONFIG_I2C_ASPEED=m CONFIG_SPI_ASPEED_SMC=m CONFIG_GPIO_ASPEED_SGPIO=y CONFIG_SENSORS_ASPEED=m CONFIG_VIDEO_ASPEED=m CONFIG_DRM_ASPEED_GFX=m CONFIG_USB_ASPEED_VHUB=m CONFIG_RTC_DRV_ASPEED=m CONFIG_ASPEED_LPC_CTRL=m CONFIG_ASPEED_LPC_SNOOP=m CONFIG_ASPEED_P2A_CTRL=m CONFIG_ASPEED_ADC=m CONFIG_FSI_MASTER_ASPEED=m Presumably not all but a lot of these are also used on AST2700. Arnd