On 01/08/2024 11:29, Cristian Ciocaltea wrote: >>> + interrupts: >>> + minItems: 4 >>> + maxItems: 5 >>> + items: >>> + - description: AVP Unit interrupt >>> + - description: CEC interrupt >>> + - description: eARC RX interrupt >>> + - description: Main Unit interrupt >>> + additionalItems: true >>> + >>> + interrupt-names: >>> + minItems: 4 >>> + maxItems: 5 >>> + items: >>> + - const: avp >>> + - const: cec >>> + - const: earc >>> + - const: main >>> + additionalItems: true >> >> Sorry, there is no user of this and nothing here is actually common >> except first entries in clocks and interrupts properties. >> >> I don't see any benefit of this. > > Sorry, I should have better indicated this is part of a larger changeset - > the cover mentions this is a reworked version of an initial (larger) series > and the split has been explicitly suggested during the review. This split is really odd. It creates unnecessary dependency, blocks automated testing and confuses reviewers because reviewers expect common code followed by its user. Best regards, Krzysztof
