On Thu, Aug 01, 2024 at 06:29:46PM GMT, Marco Felsch wrote: > Hi, > > On 24-08-01, Xu Yang wrote: > > On Thu, Aug 01, 2024 at 02:49:33PM +0300, Dmitry Baryshkov wrote: > > > On Thu, Aug 01, 2024 at 02:49:05PM GMT, Xu Yang wrote: > > > > Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware > > > > used for connecting, disconnecting and switching orientation of > > > > the SuperSpeed lines in USB Type-C applications. > > > > > > > > PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf > > > > > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > > > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx> > > > > > > > > --- > > > > Changes in v2: > > > > - add Acked-by tag > > > > - s/SBU/SuperSpeed in commit message > > > > --- > > > > Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > > > index 8a5f837eff94..152849f744c1 100644 > > > > --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > > > +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > > > @@ -20,6 +20,7 @@ properties: > > > > items: > > > > - enum: > > > > - nxp,cbdtu02043 > > > > + - nxp,ptn36043 > > > > > > PTN36043 isn't an SBU mux, so it is incorrect to declare that it is > > > compatible with the "gpio-sbu-mux". > > > > Well, so I should create a compatible such as "gpio-ss-mux" and make some > > changes on the driver, right? > > You're aware that I already sent patches regarding this topic: > > https://lore.kernel.org/all/20230504-b4-v6-3-topic-boards-imx8mp-evk-dual-role-usb-v2-0-3889b1b2050c@xxxxxxxxxxxxxx I browsed through your series. I think it has the same problem: it underrepresents the SS signals. You have specified the SS signals between the connector and PTN36043. Please also add the SS signals going between PTN36043 and your USB host or PHY. Moreover, there is no such thing as just "gpio-ss-mux", there is an NXP chip which providess SS mux / switching functionality (I think the datasheet calls it a switch, maybe that's a better name), so there should be two compatibles for the device (like all the gpio-sbu-mux devices have). > > Regards, > Marco > > > > > Thanks, > > Xu Yang > > > > > > > > > - onnn,fsusb43l10x > > > > - pericom,pi3usb102 > > > > - ti,tmuxhs4212 > > > > -- > > > > 2.34.1 > > > > > > > > > > -- > > > With best wishes > > > Dmitry > > > > -- With best wishes Dmitry
