On 01/08/2024 01:02, Alessandro Zanni wrote: Thank you for your patch. There is something to discuss/improve. > diff --git a/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml > new file mode 100644 > index 000000000000..78fbe31e4a2b > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.yaml Filename like compatible, so altr,sdram-edac.yaml Fix the placement - arm is only for top-level sutff. This goes to memory-controllers or edac > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/altera/socfpga-sdram-edac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Altera SOCFPGA SDRAM Error Detection & Correction [EDAC] > + > +maintainers: > + - Dinh Nguyen <dinguyen@xxxxxxxxxx> > + > +description: > + The EDAC accesses a range of registers in the SDRAM controller. > + > +properties: > + compatible: > + oneOf: Drop oneOf > + - items: Drop items, just use enum > + - enum: > + - altr,sdram-edac > + - altr,sdram-edac-a10 > + > + altr,sdr-syscon: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle of the sdr module > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - altr,sdr-syscon > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + sdramedac { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation e.g. memory-controller > + compatible = "altr,sdram-edac"; > + altr,sdr-syscon = <&sdr>; > + interrupts = <0 39 4>; Use proper defines. > + }; > + > +... Best regards, Krzysztof
