Hi Bryan, On 7/9/24 19:06, Depeng Shao wrote:
From: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> A .data field in the csiphy device structure allows us to extend out the register layout of the three phase capable CSIPHY layer. Move the existing lane configuration structure to an encapsulating structure -> struct csiphy_device_regs which is derived from the .data field populated at PHY init time, as opposed to calculated at lane configuration. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> Signed-off-by: Depeng Shao <quic_depengs@xxxxxxxxxxx>
in my opinion the change is good, still it might be reasonable to rename .init to something else and/or get it out of hw_ops. Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx> -- Best wishes, Vladimir
