On 31/07/2024 15:54, Krzysztof Kozlowski wrote: > On 31/07/2024 15:41, Shun-Yi Wang (王順億) wrote: >> Hi Krzysztof, >> >> Thanks for the reviews. >> >> On Wed, 2024-07-31 at 14:40 +0200, Krzysztof Kozlowski wrote: >>> >>> External email : Please do not click links or open attachments until >>> you have verified the sender or the content. >>> On 31/07/2024 14:17, Shun-yi Wang wrote: >>>> From: "shun-yi.wang" <shun-yi.wang@xxxxxxxxxxxx> >>>> >>>> Remove the maximum number of 1 for memory regions. >>> >>> Why? >>> >> >> For future applications, MTK SCP will reserve multiple regions for >> specific hardware use. > > That's not a reason to drop constrain on an entry. Maybe I was not that clear, so to explain more - entries must be constrained, so provide widest constraints in top-level properties place and narrow the constrains per variant in allOf:if:then: like: https://elixir.bootlin.com/linux/v6.8/source/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml#L132 Best regards, Krzysztof