On Wed, Jul 31, 2024 at 10:00:41AM +0200, Marc Kleine-Budde wrote: > On 30.07.2024 17:30:14, Simon Horman wrote: > > On Mon, Jul 29, 2024 at 03:05:50PM +0200, Marc Kleine-Budde wrote: > > > Add support for hardware based timestamping. > > > > > > Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > > > > Hi Marc, > > > > This patch seems to break allmodconfig builds on (at least) x86_64 > > when applied to net-next. > > > > In file included from drivers/net/can/rockchip/rockchip_canfd-ethtool.c:9: > > drivers/net/can/rockchip/rockchip_canfd.h:471:29: error: field 'cc' has incomplete type > > 471 | struct cyclecounter cc; > > The required header gets somehow pulled in on arm64, but it even fails > on arm. Fixed. Interesting times :) Thanks for addressing this, and likewise my feedback on other patches in this series.