On 31/07/2024 00:24, Elson Roy Serrao wrote: > Embedded USB Debugger(EUD) being a High-Speed USB hub needs > HS-Phy support for it's operation. Hence document phy bindings > to support this. > > Signed-off-by: Elson Roy Serrao <quic_eserrao@xxxxxxxxxxx> A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > --- > .../devicetree/bindings/soc/qcom/qcom,eud.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml > index f2c5ec7e6437..fca5b608ec63 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml > @@ -29,6 +29,14 @@ properties: > description: EUD interrupt > maxItems: 1 > > + phys: > + items: > + - description: USB2/HS PHY needed for EUD functionality > + > + phy-names: > + items: > + - const: usb2-phy > + > ports: > $ref: /schemas/graph.yaml#/properties/ports > description: > @@ -48,6 +56,8 @@ properties: > required: > - compatible > - reg > + - phys > + - phy-names That's an ABI break and nothing in commit msg justified it. Best regards, Krzysztof
