On Tue, Jul 30, 2024 at 10:58:44AM GMT, Xu Yang wrote: > On Mon, Jul 29, 2024 at 10:57:33PM +0300, Dmitry Baryshkov wrote: > > On Mon, Jul 29, 2024 at 04:10:37PM GMT, Xu Yang wrote: > > > Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware > > > used for connecting, disconnecting and switching orientation of > > > the SBU lines in USB Type-C applications. > > > > NAK, this is not correct. PTN36043 switchies SuperSpeed lines and not > > SBU. > > Yes. Since this gpio mux is able to switch both sbu line and ss line, > I will change SBU to SuperSpeed in next version in commit message to avoid > confusion. Ack. This needs new compatible and probably more schema (and driver) changes. I think you can't just terminate SS lanes in the mux, they should go to the actual SoC part (like the SS controller or PHY). > > Thanks, > Xu Yang > > > > > > > > > PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf > > > > > > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx> > > > --- > > > Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > > index 8a5f837eff94..152849f744c1 100644 > > > --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > > +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > > @@ -20,6 +20,7 @@ properties: > > > items: > > > - enum: > > > - nxp,cbdtu02043 > > > + - nxp,ptn36043 > > > - onnn,fsusb43l10x > > > - pericom,pi3usb102 > > > - ti,tmuxhs4212 > > > -- > > > 2.34.1 > > > > > > > -- > > With best wishes > > Dmitry -- With best wishes Dmitry