On 29/07/2024 08:15, hpchen0 wrote: > Add dt-bindings for USB2 PHY found on the Nuvoton MA35 SoC. > > Signed-off-by: hpchen0 <hpchen0nvt@xxxxxxxxx> Please use proper name. > --- > .../bindings/phy/nuvoton,ma35-usb2-phy.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/nuvoton,ma35-usb2-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/nuvoton,ma35-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/nuvoton,ma35-usb2-phy.yaml > new file mode 100644 > index 000000000000..415ea2c45975 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/nuvoton,ma35-usb2-phy.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/nuvoton,ma35-usb2-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton MA35 USB2 phy > + > +maintainers: > + - hpchen0 <hpchen0nvt@xxxxxxxxx> Same here > + > +properties: > + compatible: > + enum: > + - nuvoton,ma35-usb2-phy All other devices have name ma35d1. Is this a different SoC? > + > + "#phy-cells": > + const: 0 > + > + clocks: > + maxItems: 1 > + description: USB PHY clock Drop description, it's obvious. > + > + clock-names: > + const: usbd_gate Drop clock-names, you do not bring any new information. > + > + nuvoton,sys: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + phandle of the system-management node. Describe what is it for. > + > +required: > + - compatible > + - clocks > + - nuvoton,sys > + - "#phy-cells" Keep the same order as in properties. > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> Where do you use it? > + #include <dt-bindings/clock/nuvoton,ma35d1-clk.h> > + > + usb_phy: usb-phy { > + compatible = "nuvoton,ma35-usb2-phy"; > + clocks = <&clk USBD_GATE>; > + clock-names = "usbd_gate"; > + nuvoton,sys = <&sys>; > + #phy-cells = <0>; > + }; Best regards, Krzysztof
