Hello Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: Thursday, July 25, 2024 4:56 PM > To: sunyeal.hong <sunyeal.hong@xxxxxxxxxxx>; 'Rob Herring' > <robh@xxxxxxxxxx> > Cc: 'Sylwester Nawrocki' <s.nawrocki@xxxxxxxxxxx>; 'Chanwoo Choi' > <cw00.choi@xxxxxxxxxxx>; 'Alim Akhtar' <alim.akhtar@xxxxxxxxxxx>; 'Michael > Turquette' <mturquette@xxxxxxxxxxxx>; 'Stephen Boyd' <sboyd@xxxxxxxxxx>; > 'Conor Dooley' <conor+dt@xxxxxxxxxx>; linux-samsung-soc@xxxxxxxxxxxxxxx; > linux-clk@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC > CMU bindings > > On 25/07/2024 09:50, sunyeal.hong wrote: > > Hello Krzysztof, > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > >> Sent: Thursday, July 25, 2024 4:32 PM > >> To: sunyeal.hong <sunyeal.hong@xxxxxxxxxxx>; 'Rob Herring' > >> <robh@xxxxxxxxxx> > >> Cc: 'Sylwester Nawrocki' <s.nawrocki@xxxxxxxxxxx>; 'Chanwoo Choi' > >> <cw00.choi@xxxxxxxxxxx>; 'Alim Akhtar' <alim.akhtar@xxxxxxxxxxx>; > >> 'Michael Turquette' <mturquette@xxxxxxxxxxxx>; 'Stephen Boyd' > >> <sboyd@xxxxxxxxxx>; 'Conor Dooley' <conor+dt@xxxxxxxxxx>; > >> linux-samsung-soc@xxxxxxxxxxxxxxx; > >> linux-clk@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm- > >> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > >> Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 > >> SoC CMU bindings > >> > >> On 25/07/2024 09:14, sunyeal.hong wrote: > >>> Hello Krzysztof, > >>> > >>>> -----Original Message----- > >>>> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > >>>> Sent: Thursday, July 25, 2024 3:41 PM > >>>> To: sunyeal.hong <sunyeal.hong@xxxxxxxxxxx>; 'Rob Herring' > >>>> <robh@xxxxxxxxxx> > >>>> Cc: 'Sylwester Nawrocki' <s.nawrocki@xxxxxxxxxxx>; 'Chanwoo Choi' > >>>> <cw00.choi@xxxxxxxxxxx>; 'Alim Akhtar' <alim.akhtar@xxxxxxxxxxx>; > >>>> 'Michael Turquette' <mturquette@xxxxxxxxxxxx>; 'Stephen Boyd' > >>>> <sboyd@xxxxxxxxxx>; 'Conor Dooley' <conor+dt@xxxxxxxxxx>; > >>>> linux-samsung-soc@xxxxxxxxxxxxxxx; > >>>> linux-clk@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm- > >>>> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > >>>> Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 > >>>> SoC CMU bindings > >>>> > >>>> On 25/07/2024 08:37, Krzysztof Kozlowski wrote: > >>>>>> then: > >>>>>> properties: > >>>>>> clocks: > >>>>>> items: > >>>>>> - description: External reference clock (38.4 MHz) > >>>>>> - description: CMU_MISC NOC clock (from CMU_MISC) > >>>>>> > >>>>>> clock-names: > >>>>>> items: > >>>>>> - const: oscclk > >>>>>> - const: noc > >>>>>> > >>>>>> If there is anything I misunderstand, please guide me. > >>>>>> > >>>>> > >>>>> You did not address my questions at all instead just copied again > >>>>> the same. It is not how it works. > >>>>> > >>>>> I am not going to discuss like this. > >>>> > >>>> And in case it is still unclear - just look at your bindings and DTS. > >>>> They say you have three clocks! > >>>> > >>>> Best regards, > >>>> Krzysztof > >>>> > >>> > >>> Let me answer your questions first. > >>> In the existing V4 patch, clock items were declared in if then for > >>> each > >> block, so there was no problem. > >> > >> No. Again, look at your binding and DTS. > >> > >> 1. What clocks did you define for cmu-top? > > Cmu-top has one clock(oscclk). > >> 2. What clocks did you define for cmu-peric0? > > Cmu-peric0 has three clocks(oscclk, noc and ip) > >> > >> Rob's advice is reasonable and you must follow it, unless you are not > >> telling us something. There is no other choice, no other compatibles, > >> no other devices. > >> > > Yes, that's right. In this patch, modifications are possible according > to Rob's review. > >>> If modified according to Rob's comment, problems may occur as the > >>> input > >> clock is configured differently for each block. > >> > >> But it is not! Look at your binding. > > The reason I mentioned this was to ask how to handle problems that may > occur when adding cmu for a new block in a new patch. > > As you mentioned, this issue does not exist in this patch. > > A new block? And how do we know about it? Bindings are supposed to be > complete. We see bindings and you receive review. > > Post complete bindings. > > Best regards, > Krzysztof > I understand your intention. I will re-upload the patch based on Rob's review based on the current patch. Best regards, sunyeal
