On Fri, Jul 26, 2024 at 04:19:51AM -0400, Emil Renner Berthing wrote: > Drew Fustini wrote: > > On Fri, Jul 05, 2024 at 03:04:58PM +0530, Kanak Shilledar wrote: > > > Implemented basic SPI support for TH1520 SoC. There are two SPIs reserved > > > on the LicheePi4A, one on the SPI Flash pads that are blanked out on the > > > back, and one on the pins. I implemented the one connected to the pad. > > > > > > It is using a fixed clock of 396MHz. The address and clock frequency was > > > referenced from the TH1520 System Reference Manual [1]. > > > > > > [...] > > > > Applied to thead-dt-for-next, thanks! > > Hi Drew, > > Are you sure you want to merge this patch? It adds another dummy clock for the > SPI, but the next kernel should have your clock driver that actually models the > SPI clock. > Also the clock driver says the SPI clock has a frequency of 792MHz, eg. double > of what this dummy clock is set to. > > /Emil I am planning send updated dts patches for thead,th1520-clk-ap support that addresses your recent comment [1]. I'll include a patch to convert the SPI clock similar to the other dts patches in that series. Assuming there are no issues with that new series, I will apply them to thead-dt-for-next with enough testing time for them to be included in the 6.12 pull request to Arnd. Thanks, Drew [1] https://lore.kernel.org/linux-riscv/CAJM55Z8uo-Z_9ruyqygK1pbBCTkCxMBVoF8GD2dajhTKOYrAfA@xxxxxxxxxxxxxx/
