> -----Original Message-----
> From: Bjorn Helgaas <helgaas@xxxxxxxxxx>
> Sent: 2024年7月26日 4:44
> To: Hongxing Zhu <hongxing.zhu@xxxxxxx>
> Cc: robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx;
> shawnguo@xxxxxxxxxx; l.stach@xxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-pci@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 0/4] Add dbi2 and atu for i.MX8M PCIe EP
>
> On Thu, Jul 25, 2024 at 03:35:12PM +0800, Richard Zhu wrote:
> > v3 changes:
> > - Refine the commit descriptions.
> >
> > v2 changes:
> > Thanks for Conor's comments.
> > - Place the new added properties at the end.
> >
> > Ideally, dbi2 and atu base addresses should be fetched from DT.
> > Add dbi2 and atu base addresses for i.MX8M PCIe EP here.
> >
> > [PATCH v3 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu"
> > [PATCH v3 2/4] dts: arm64: imx8mq: Add dbi2 and atu reg for i.MX8MQ
> > [PATCH v3 3/4] dts: arm64: imx8mp: Add dbi2 and atu reg for i.MX8MP
> > [PATCH v3 4/4] dts: arm64: imx8mm: Add dbi2 and atu reg for i.MX8MM
> >
> > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml | 13
> +++++++++----
> > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 8
> +++++---
> > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 7
> +++++--
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8
> +++++---
> > 4 files changed, 24 insertions(+), 12 deletions(-)
>
> For all the patches in this series, can you please:
>
> - Separate paragraphs with blank lines so we know where they end.
>
> - Wrap commit log to fill 75 columns.
Hi Bjorn:
Sure.
How about to change the commit message to the following format?
"
Add reg-name: "dbi2", "atu" for i.MX8M PCIe Endpoint.
For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
driver. This method is not good.
In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
Frank suggests to fetch the dbi2 and atu from DT directly. This commit is
preparation to do that for i.MX8M PCIe EP.
These changes wouldn't break driver function. When "dbi2" and "atu"
properties are present, i.MX PCIe driver would fetch the according base
addresses from DT directly. If only two reg properties are provided, i.MX
PCIe driver would falls back to the old method.
"
Thanks for your comments.
Best Regards
Richard Zhu
