On Thu, Jul 25, 2024 at 10:13:07AM GMT, Johan Hovold wrote: > On Thu, Jul 25, 2024 at 10:49:41AM +0300, Dmitry Baryshkov wrote: > > On Thu, 25 Jul 2024 at 09:17, Johan Hovold <johan@xxxxxxxxxx> wrote: > > > On Wed, Jul 24, 2024 at 08:22:54PM +0300, Dmitry Baryshkov wrote: > > > > On Tue, Jul 23, 2024 at 05:13:28PM GMT, Johan Hovold wrote: > > > > > > Note that this property has been part of the Qualcomm PCIe bindings > > > > > since 2018 and would need to be deprecated rather than simply removed if > > > > > there is a desire to replace it with 'vpcie3v3' which is used for some > > > > > non-Qualcomm controllers. > > > > > > > > I think Rob Herring suggested [1] adding the property to the root port > > > > node rather than the host. If that suggestion still applies it might be > > > > better to enable the deprecated propertly only for the hosts, which > > > > already used it, and to define a new property at the root port. > > > > > > You seem to miss the point that this is just restoring status quo (and > > > that the property has not yet been deprecated). > > > > You are restoring it for all platforms. > > It is already part of the bindings for all platforms. It is not, it is enabled only for sc7280 and sc8280xp. It has been, before the mentioned patch. I propopse to enable the property for the platforms which are using it now (that is +x1e80100, msm8996 and sdm845), clearly document it as deprecated and start shifting to the pwrseq and having the power supplies being a part of the root port or wcn device, depending on the use case. -- With best wishes Dmitry
