Hi Maxime, On 9 March 2015 at 11:03, Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > Hi Tyler, > > On Mon, Mar 09, 2015 at 09:27:00AM -0700, tyler.baker@xxxxxxxxxx wrote: >> From: Tyler Baker <tyler.baker@xxxxxxxxxx> >> >> Add a Cubietech Cubieboard4 device tree and instruct make to build it. This >> device tree has been derived from the sun9i-a80-optimus.dts as they are very >> similar in design[1]. Notably, I2C3 is not used on Cubieboard4 and the LED/PWM >> definitions will need to be updated in the future. >> >> [1] http://dl.cubieboard.org/model/cc-a80/Hardware/CC-A80-HW-V1.1.pdf >> >> Signed-off-by: Tyler Baker <tyler.baker@xxxxxxxxxx> >> --- >> arch/arm/boot/dts/Makefile | 3 +- >> arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 99 +++++++++++++++++++++++++++++ >> 2 files changed, 101 insertions(+), 1 deletion(-) >> create mode 100644 arch/arm/boot/dts/sun9i-a80-cubieboard4.dts >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index 4837044..0f67dab 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -553,7 +553,8 @@ dtb-$(CONFIG_MACH_SUN8I) += \ >> sun8i-a23-ippo-q8h-v5.dtb \ >> sun8i-a23-ippo-q8h-v1.2.dtb >> dtb-$(CONFIG_MACH_SUN9I) += \ >> - sun9i-a80-optimus.dtb >> + sun9i-a80-optimus.dtb \ >> + sun9i-a80-cubieboard4.dtb >> dtb-$(CONFIG_ARCH_TEGRA_2x_SOC) += \ >> tegra20-harmony.dtb \ >> tegra20-iris-512.dtb \ >> diff --git a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts > > Good catch on the file name. > >> new file mode 100644 >> index 0000000..5cdc165 >> --- /dev/null >> +++ b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts >> @@ -0,0 +1,99 @@ >> +/* >> + * Copyright 2015 Tyler Baker >> + * >> + * Tyler Baker <tyler.baker@xxxxxxxxxx> >> + * Chen-Yu Tsai <wens@xxxxxxxx> >> + * >> + * This file is dual-licensed: you can use it either under the terms >> + * of the GPL or the X11 license, at your option. Note that this dual >> + * licensing only applies to this file, and not this project as a >> + * whole. >> + * >> + * a) This file is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of the >> + * License, or (at your option) any later version. >> + * >> + * This file is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * Or, alternatively, >> + * >> + * b) Permission is hereby granted, free of charge, to any person >> + * obtaining a copy of this software and associated documentation >> + * files (the "Software"), to deal in the Software without >> + * restriction, including without limitation the rights to use, >> + * copy, modify, merge, publish, distribute, sublicense, and/or >> + * sell copies of the Software, and to permit persons to whom the >> + * Software is furnished to do so, subject to the following >> + * conditions: >> + * >> + * The above copyright notice and this permission notice shall be >> + * included in all copies or substantial portions of the Software. >> + * >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> + * OTHER DEALINGS IN THE SOFTWARE. >> + */ >> + >> +/dts-v1/; >> +#include "sun9i-a80.dtsi" >> +#include "sunxi-common-regulators.dtsi" >> + >> +#include <dt-bindings/gpio/gpio.h> >> +#include <dt-bindings/pinctrl/sun4i-a10.h> >> + >> +/ { >> + model = "Cubietech Cubieboard4"; >> + compatible = "cubietech,a80-cubieboard4", "allwinner,sun9i-a80"; >> + >> + aliases { >> + serial0 = &uart0; >> + }; >> + >> + chosen { >> + linux,stdout-path = &uart0; > > Actually, you can just use stdout-path, and you can also provide the > baudrate configuration (and reuse the alias you just defined) by using > > stdout-path = "serial0:115200n8"; Ah, ok. Your suggested notation is more descriptive, I'll update it in v2. > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com Thanks, Tyler -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html