Re: [PATCH v3 3/5] dt-bindings: display: st7701: Add Anbernic RG28XX panel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 10/07/2024 16:01, Conor Dooley wrote:
On Sat, Jul 06, 2024 at 07:23:34PM +0900, Hironori KIKUCHI wrote:
The RG28XX panel is a display panel of the Anbernic RG28XX, a handheld
gaming device from Anbernic. It is 2.8 inches in size (diagonally) with
a resolution of 480x640.

This panel is driven by a variant of the ST7701 driver IC internally,
confirmed by dumping and analyzing its BSP initialization sequence
by using a logic analyzer. It is very similar to the existing
densitron,dmt028vghmcmi-1a panel, but differs in some unknown
register values, so add a new entry for the panel to distinguish them.

Additionally, the panel only has an SPI instead of MIPI DSI.
So add and modify for SPI as well.

Signed-off-by: Hironori KIKUCHI <kikuchan98@xxxxxxxxx>

With a mention in the commit message about why we are adding a property
and then immediately forbidding its use:
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Can you resend a v4 with this suggestion ?

Thanks,
Neil


Thanks,
Conor.





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux