Il 23/07/24 11:56, Hsin-Te Yuan ha scritto:
Cerise is known as ASUS Chromebook CZ1.
Stern is known as ASUS Chromebook Flip CZ1.
Signed-off-by: Hsin-Te Yuan <yuanhsinte@xxxxxxxxxxxx>
---
.../dts/mediatek/mt8183-kukui-jacuzzi-cerise.dts | 25 ++++++++++++++++
.../dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi | 21 +++++++++++++
.../dts/mediatek/mt8183-kukui-jacuzzi-stern.dts | 35 ++++++++++++++++++++++
3 files changed, 81 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dts
new file mode 100644
index 000000000000..b4f4ed701253
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dts
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2021 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8183-kukui-jacuzzi-cerise.dtsi"
+#include "mt8183-kukui-audio-da7219-rt1015p.dtsi"
+
+/ {
+ model = "Google cerise board";
+ compatible = "google,cerise-sku0", "google,cerise", "mediatek,mt8183";
+};
+
+&mt6358codec {
+ mediatek,dmic-mode = <1>; /* one-wire */
+};
+
+&touchscreen {
+ status = "disabled";
+};
+
+&qca_wifi {
+ qcom,ath10k-calibration-variant = "GO_CERISE";
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi
new file mode 100644
index 000000000000..087a0ef33e13
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2021 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8183-kukui-jacuzzi.dtsi"
+
+&cpu_thermal {
+ sustainable-power = <4500>; /* milliwatts */
+};
+
+&mmc1_pins_uhs {
+ pins-clk {
+ drive-strength = <MTK_DRIVE_6mA>;
+ };
+};
+
+&i2c2 {
+ i2c-scl-internal-delay-ns = <13200>;
+};
It's really just a few lines, unless more than two devicetrees use those, I'm
more for just putting those in cerise.dts and stern.dts instead of having yet
another dtsi to walk through...
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-stern.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-stern.dts
new file mode 100644
index 000000000000..15e00feae3a9
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-stern.dts
@@ -0,0 +1,35 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2021 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8183-kukui-jacuzzi-cerise.dtsi"
+#include "mt8183-kukui-audio-da7219-rt1015p.dtsi"
+
+/ {
+ model = "Google stern board";
+ compatible = "google,cerise-sku1", "google,cerise", "mediatek,mt8183";
+};
+
+&mt6358codec {
+ mediatek,dmic-mode = <0>; /* two-wire */
+};
+
+&touchscreen {
You are referencing to the touchscreen@10 node from mt8183-kukui-jacuzzi.dtsi...
+ status = "okay";
...which is not disabled by default, so this property is useless, and
+
+ compatible = "hid-over-i2c";
It's originally elan,ekth3500, you override it with hid-over-i2c, that's ok, but
+ reg = <0x10>;
the node already has this property....
+ interrupt-parent = <&pio>; > + interrupts = <155 IRQ_TYPE_LEVEL_LOW>;
...and this one, actually even better, it's using interrupts-extended instead...
+ pinctrl-names = "default";
+ pinctrl-0 = <&touchscreen_pins>;
....and it's the same for this
+
+ post-power-on-delay-ms = <10>;
+ hid-descr-addr = <0x0001>;
...but those two aren't present.
So you only need three properties in here :-)
+};
+
Apart from that, there's no google,cerise (nor the skus, of course) in the bindings
so please add those to arm/mediatek.yaml between Burnet and Cozmo; only then I will
be able to accept new board dts.
Thanks!
Angelo
