Hi Hervé and Clément, On Thu, Jun 27, 2024 at 11:13 AM Herve Codina <herve.codina@xxxxxxxxxxx> wrote: > From: Clément Léger <clement.leger@xxxxxxxxxxx> > > The sparx5 reset controller depends on the SPARX5 architecture or the > LAN966x SoC. > > This reset controller can be used by the LAN966x PCI device and so it > needs to be available on all architectures. > Also the LAN966x PCI device driver can be built as a module and this > reset controller driver has no reason to be a builtin driver in that > case. > > Signed-off-by: Clément Léger <clement.leger@xxxxxxxxxxx> > Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx> Thanks for your patch! > --- a/drivers/reset/Kconfig > +++ b/drivers/reset/Kconfig > @@ -124,8 +124,7 @@ config RESET_LPC18XX > This enables the reset controller driver for NXP LPC18xx/43xx SoCs. > > config RESET_MCHP_SPARX5 > - bool "Microchip Sparx5 reset driver" > - depends on ARCH_SPARX5 || SOC_LAN966 || COMPILE_TEST > + tristate "Microchip Sparx5 reset driver" This opens up the question to everyone, so I'd rather add a dependency on MFD_LAN966X_PCI. > default y if SPARX5_SWITCH > select MFD_SYSCON > help Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds